-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vignettes/variation #225
Vignettes/variation #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start @kellymccain28 👌.
A few specific changes requested and also a comment about if we want to include this as part of a larger vignette including the parameter draw uncertatinty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kelly, nice work (esp in figuring out all that base plotting code ...). Comments and a few responses to Pete :)
…riasimulation into vignettes/variation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments from me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Just a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kellymccain28,
Looking good. In the final plot it looks like PfPR starts at 0
This can't be correct otherwise there wouldn't be any transmission later on. Can you double check if it is a processing/plotting issue? It might help to plot those last two PfPr plots on a ylim scale of (0, 0.2) to better see what is going on
Updates to the variation vignette include: