Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignettes/variation #225

Merged
merged 21 commits into from
May 24, 2023
Merged

Vignettes/variation #225

merged 21 commits into from
May 24, 2023

Conversation

kellymccain28
Copy link
Contributor

Updates to the variation vignette include:

  • Removal of ggplot2 dependency
  • Removal of references to p_detect (I was not sure what the purpose of including the distinction between n_detect and p_detect was, so I removed it to focus on the random variation in the model based on population size, but happy to add it back in.)
  • Updating and adding explanations/slight reorganizing

Copy link
Member

@pwinskill pwinskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start @kellymccain28 👌.
A few specific changes requested and also a comment about if we want to include this as part of a larger vignette including the parameter draw uncertatinty

vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
Copy link
Contributor

@htopazian htopazian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kelly, nice work (esp in figuring out all that base plotting code ...). Comments and a few responses to Pete :)

vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
Copy link
Member

@pwinskill pwinskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments from me :)

vignettes/Variation.Rmd Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
@kellymccain28 kellymccain28 requested a review from pwinskill March 28, 2023 17:17
Copy link
Contributor

@htopazian htopazian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Just a few comments

vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
vignettes/Variation.Rmd Outdated Show resolved Hide resolved
Copy link
Member

@pwinskill pwinskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kellymccain28,

Looking good. In the final plot it looks like PfPR starts at 0
image

This can't be correct otherwise there wouldn't be any transmission later on. Can you double check if it is a processing/plotting issue? It might help to plot those last two PfPr plots on a ylim scale of (0, 0.2) to better see what is going on

@kellymccain28
Copy link
Contributor Author

For the final plot, I changed the seed so it starts at >0% prevalence and reduced the y axis limits to c(0,0.2) as suggested. THere is a point in the plot here where the number of cases detected is at 0 for a timestep then goes back up to >0 which I think makes sense as there will still be infecitous mosquitoes buzzing around that could infect people
image

@kellymccain28 kellymccain28 requested a review from pwinskill April 21, 2023 11:35
@pwinskill pwinskill merged commit a6334f3 into vignettes_update May 24, 2023
@RJSheppard RJSheppard deleted the vignettes/variation branch October 3, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants